[Bug 785679] element: add gst_element_foreach_*pad()
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Aug 3 16:15:17 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=785679
--- Comment #9 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
My patch is thread-safe just fine :)
I would argue that properly supporting iterator resync doesn't really make
anything more thread-safe from a global element perspective, since if the
function was called just a bit earlier the element would still have to handle
the new pad correctly, and for removed pads it doesn't really matter anyway.
This is for the normal case where pads are added/removed from another thread.
The only case I can think of where it makes a difference is if pads get
added/removed from the callback function itself.
I quite dislike GstIterator, it causes allocs/frees and way too much
lock/unlock, and your patch using GArray causes even more allocs/frees :/
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list