[Bug 785679] element: add gst_element_foreach_*pad()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Aug 3 19:24:33 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785679

--- Comment #10 from Olivier CrĂȘte <olivier.crete at ocrete.ca> ---
Review of attachment 356714:
 --> (https://bugzilla.gnome.org/review?bug=785679&attachment=356714)

Oh I wasn't all there when I first read your patch, clearly it's thread safe.
Probably indeed much more simple than my approach for similar result.

::: gst/gstelement.c
@@ +1263,3 @@
+  GST_OBJECT_LOCK (element);
+  n_pads = *p_npads;
+  pads = g_newa (GstPad *, n_pads + 1);

why + 1 ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list