[Bug 785948] audioencoder: Integer overflows in timestamp/granulepos calculation code on discont

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Aug 7 20:00:02 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785948

--- Comment #2 from Mark Nauwelaerts <mnauw at users.sourceforge.net> ---
When writing the second code-fragment, I was assuming to have enough time-slack
to handle the diff.  But indeed, the base_ts is usually 0 (or thereabout). 
However, there is a lot of slack in the sample count, so we could do it as in
attached patch.  That avoid the tricky-ness of a negative ts, and only errors
out if things are really bad.

Applying the "discont-wait" could indeed make things a bit less jitterish and
align it with audiobasesink (as it was once originally).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list