[Bug 785948] audioencoder: Integer overflows in timestamp/granulepos calculation code on discont

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785948

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357142|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 357142:
 --> (https://bugzilla.gnome.org/review?bug=785948&attachment=357142)

Looks good to me, please add some further details about what and why and how to
the commit message though :) Thanks for the fast patch!

::: gst-libs/gst/audio/gstaudioencoder.c
@@ +1330,3 @@
+          GST_SECOND, ctx->info.rate * ctx->info.bpf);
+
+      if (shift > GST_BUFFER_TIMESTAMP (buffer)) {

I think this can never happen, or can it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.