[Bug 785948] audioencoder: Integer overflows in timestamp/granulepos calculation code on discont

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Aug 8 18:22:48 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=785948

--- Comment #4 from Mark Nauwelaerts <mnauw at users.sourceforge.net> ---
It is very unlikely to happen.  It theoretically could if after (say) 5s
another buffer would come in with ts 0 while still some other stuff in the
adapter.  Then I would not want to be caught trying to subtract into the
negative, but as said things are already pretty weird for that to happen.  But
I suppose it's then better to error out than to have more weird stuff
happening.  A G_UNLIKELY could be sprinkled there for good measure.

I shall also endeavour to restrain succinct proclivity ...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list