[Bug 783521] gl: Add "direct" dmabuf uploader

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=783521

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357449|none                        |needs-work
             status|                            |

--- Comment #9 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 357449:
 --> (https://bugzilla.gnome.org/review?bug=783521&attachment=357449)

The native platform interface is the only way to get at some Qt resources. as
long as there's nothing better, using it is ok.

::: ext/qt/gstqtglutility.cc
@@ +122,3 @@
+    EGLDisplay egl_display = (EGLDisplay)
+        native->nativeResourceForWindow("egldisplay", NULL);
+    display = (GstGLDisplay *) gst_gl_display_egl_new_with_egl_display
(egl_display);

What if egl_display is invalid?

Also, this code will always be run when libgstgl is GST_GL_HAVE_WINDOW_GBM
enabled and realistically, could probably replace the next #else cause so you
don't need to #elif GST_GL_HAVE_WINDOW_GBM.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.