[Bug 786348] omx: Ports should be disabled sequentially

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786348

Guillaume Desmottes <gdesmott at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357691|none                        |reviewed
             status|                            |

--- Comment #1 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 357691:
 --> (https://bugzilla.gnome.org/review?bug=786348&attachment=357691)

Looks good modulo comment.

Tested on rpi and zynqultrascaleplus.

::: omx/gstomxaudioenc.c
@@ +697,3 @@
+      /* Disabling at the same time input port and output port is only
+       * required when a buffer is shared between the ports. This cannot
+       * be the case for a decoder because its input and output buffers

it's an encoder here. So maybe say "encoder/decoder".

::: omx/gstomxvideoenc.c
@@ +1006,3 @@
+    /* Disabling at the same time input port and output port is only
+     * required when a buffer is shared between the ports. This cannot
+     * be the case for a decoder because its input and output buffers

same here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.