[Bug 786348] omx: Ports should be disabled sequentially

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786348

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #357691|reviewed                    |committed
             status|                            |

--- Comment #2 from Julien Isorce <julien.isorce at gmail.com> ---
Comment on attachment 357691
  --> https://bugzilla.gnome.org/attachment.cgi?id=357691
omx{audio,video}{dec,enc}: sequentially disable ports because buffers are not
shared

Done thx !

commit eec88a965106d66e1b327b9bc15a114b6b0f262e
Author: Julien Isorce <jisorce at oblong.com>
Date:   Thu Jul 20 09:43:19 2017 +0100

    omx{audio,video}{dec,enc}: sequentially disable ports because buffers are
not shared

    For the history, the parallel disable port has been introduced by:
    "00be69f omxvideodec: Disable output port when setting a new format"
    and then replicated to videoenc, audiodec and audioenc.

    This is only required to do 'parallel' if buffers are shared between ports.
    But for decoders and encoders the input and output buffer are of different
    nature by definition (bitstream vs images). So they cannot be shared.

    Also starting from IL 1.2.0 it is written in the spec that the parallel
    disable is not allowed and will return an error. Except when buffers are
    shared.

    Again here we know in advance that they are not shared so let's always
    do a sequential disable.

    Tested on Desktop, rpi and zynqultrascaleplus.

    https://bugzilla.gnome.org/show_bug.cgi?id=786348

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.