[Bug 784779] gl: public gstgl headers should not include GL headers
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Aug 22 10:50:42 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=784779
--- Comment #17 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Matthew Waters (ystreet00) from comment #16)
> Review of attachment 357732 [details] [review]:
>
> Looks ok to me. Feel free to push after changing the comment.
>
> Are you going to look into the other platform-specific headers?
Like for example XLib.h included from gstgl_window_x11.h ? not any time soon so
feel free to go ahead.
>
> ::: tests/check/libs/gstglheaders.c
> @@ +26,3 @@
> +
> +/* This test check that public gstgl headers does not include any
> + * GL headers. Except for gst/gl/gstglfuncs.h and gst/gl/gl.h */
>
> Comment is not quite correct anymore.
>
> gst/gl/gl.h is included
Done. Thx for the review.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list