[Bug 784779] gl: public gstgl headers should not include GL headers
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Aug 22 10:51:07 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=784779
Julien Isorce <julien.isorce at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #357732|reviewed |committed
status| |
--- Comment #18 from Julien Isorce <julien.isorce at gmail.com> ---
Comment on attachment 357732
--> https://bugzilla.gnome.org/attachment.cgi?id=357732
gl: do not include GL headers in public gstgl headers
commit 2fd84a6c867641b53529de727ac72549b299a6f8
Author: Julien Isorce <jisorce at oblong.com>
Date: Fri Jul 7 16:15:12 2017 +0100
gl: do not include GL headers in public gstgl headers
Except for gst/gl/gstglfuncs.h
It is up to the client app to include these headers.
It is coherent with the fact that gstreamer-gl.pc does not
require any egl.pc/gles.pc. I.e. it is the responsability
of the app to search these headers within its build setup.
For example gstreamer-vaapi includes explicitly EGL/egl.h
and search for it in its configure.ac.
For example with this patch, if an app includes the headers
gst/gl/egl/gstglcontext_egl.h
gst/gl/egl/gstgldisplay_egl.h
gst/gl/egl/gstglmemoryegl.h
it will *no longer* automatically include EGL/egl.h and GLES2/gl2.h.
Which is good because the app might want to use the gstgl api only
without the need to bother about gl headers.
Also added a test: cd tests/check && make libs/gstglheaders.check
https://bugzilla.gnome.org/show_bug.cgi?id=784779
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list