[Bug 732267] h264parse: extract base stream from MVC or SVC encoded streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732267

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358002|none                        |needs-work
             status|                            |

--- Comment #14 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 358002:
 --> (https://bugzilla.gnome.org/review?bug=732267&attachment=358002)

::: gst/videoparsers/gsth264parse.c
@@ +721,3 @@
+  caps = gst_caps_new_simple ("video/x-h264", "profile", G_TYPE_STRING,
+      profile_str, NULL);
+}

mem leak, caps not freed

@@ +764,3 @@
+        return TRUE;
+      }
+        h264parse->base_only = TRUE;

Why resetting base_only to "FALSE" in each iteration?

@@ +964,3 @@
+  }
+}
+

I think this is going to affect the performance of generic (non-mvc/non-svc)
use cases.

Before(with out this code) we were only invoking the
gst_h264_parser_identify_nalu_unchecked() in gst_h264_parse_collect_nal(),
because we only needed to know the nex nal type and header.

With your code, all most all nal units required to invoke the
gst_h264_parser_identify_nalu() which involves two start_code scanning and it
is unnecessary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.