[Bug 732267] h264parse: extract base stream from MVC or SVC encoded streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732267

Orestis Floros <orestisf1993 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358002|needs-work                  |none
             status|                            |
 Attachment #358002|0                           |1
        is obsolete|                            |

--- Comment #15 from Orestis Floros <orestisf1993 at gmail.com> ---
Created attachment 358539
  --> https://bugzilla.gnome.org/attachment.cgi?id=358539&action=edit
h264parse: extract base view from MVC or SVC streams

(In reply to sreerenj from comment #14)
> Review of attachment 358002 [details] [review]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +721,3 @@
> +  caps = gst_caps_new_simple ("video/x-h264", "profile", G_TYPE_STRING,
> +      profile_str, NULL);
> +}
> 
> mem leak, caps not freed
> 
> @@ +764,3 @@
> +        return TRUE;
> +      }
> +        h264parse->base_only = TRUE;
> 
> Why resetting base_only to "FALSE" in each iteration?

Fixed.

> @@ +964,3 @@
> +  }
> +}
> +
> 
> I think this is going to affect the performance of generic (non-mvc/non-svc)
> use cases.
> 
> Before(with out this code) we were only invoking the
> gst_h264_parser_identify_nalu_unchecked() in gst_h264_parse_collect_nal(),
> because we only needed to know the nex nal type and header.
> 
> With your code, all most all nal units required to invoke the
> gst_h264_parser_identify_nalu() which involves two start_code scanning and
> it is unnecessary.

Yes. I think with this patch the performance of generic cases shouldn't be
affected and the extra cost for MVC / SVC streams is acceptable and necessary
imo. Also, for the case of an MVC / SVC stream without base_only only prefix
units have the extra cost and they are small.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.