[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364888|none                        |reviewed
             status|                            |

--- Comment #21 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364888:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=364888)

::: sys/msdk/msdk.h
@@ +67,3 @@
 const gchar *msdk_status_to_string (mfxStatus status);

+void msdk_video_alignment (GstVideoAlignment * alignment, GstVideoInfo *
info);

I don't like the function name, it is not auto-documented.

Think something like gst_msdk_set_video_alignment. Also, if you are going to
need only the number of planes, there is no need to pass all the GstVideoInfo
structure pointer, just pass the guint planes_num,

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.