[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364889|none                        |rejected
             status|                            |

--- Comment #22 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364889:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=364889)

::: sys/msdk/msdk.c
@@ +381,3 @@
     alignment->padding_bottom = 32 - (height & 31);
 }
+

I am not fancy of switch structures for this kind of operations. I prefer to
define static structures which map one data with the other. Thus, the functions
are a loop that looks the search item and returns the associated one in the map
table.

@@ +383,3 @@
+
+gint
+msdk_get_mfx_color_format (GstVideoFormat format)

as it is an exported function I would call it
gst_msdk_get_mfx_chroma_from_format()

chroma is different from color format

@@ +405,3 @@
+
+gint
+msdk_get_mfx_fourcc (GstVideoFormat format)

This function is useless since we already have gst_video_format_to_fourcc ()

@@ +428,3 @@
+void
+msdk_convert_video_info_to_mfx_info (GstVideoInfo * info,
+    mfxFrameInfo * mfx_info)

I'd rename this function to gst_msdk_set_mfx_frame_info_from_video_info
(mfxFrameInfo *, GstVideoInfo *)

@@ +440,3 @@
+  mfx_info->AspectRatioW = info->par_n;
+  mfx_info->AspectRatioH = info->par_d;
+  mfx_info->PicStruct = MFX_PICSTRUCT_PROGRESSIVE;

you can get this also from the gstvideoinfo:

info->interlace_mode

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.