[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #33 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364989:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=364989)

::: sys/msdk/msdk.c
@@ +53,3 @@
+  { GST_VIDEO_FORMAT_BGRA,   MFX_CHROMAFORMAT_YUV444,  MFX_FOURCC_RGB4    },
+  { 0, 0, 0 }
+/* *INDENT-ON* */

you can fancy up this code with macros ;)

@@ +404,3 @@
+
+static const struct map *
+_map_lookup_format (const struct map *m, GstVideoFormat format)

as it is a static structure and the function is not recursive, there is no need
to pass it as argument

@@ +439,3 @@
+  g_return_if_fail (info && mfx_info);
+
+  mfx_info->Width = GST_ROUND_UP_32 (info->width);

what about use the respective macros to get the width, height, fps, par, and
format?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.