[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364992|none                        |rejected
             status|                            |

--- Comment #34 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364992:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=364992)

::: sys/msdk/gstmsdkmemory.c
@@ +157,3 @@
+  surface = (mfxFrameSurface1 *) g_slice_new0 (mfxFrameSurface1);
+
+  g_return_val_if_fail (surface, NULL);

don't use g_return_val_if_fail() for system errors. It is only for misuse of
API from users.
use the normal

if (!surface) {
GST_ERROR()
return NULL;
}

@@ +177,3 @@
+
+  allocator = GST_MSDK_ALLOCATOR_CAST (base_allocator);
+  g_return_val_if_fail (GST_IS_MSDK_ALLOCATOR (allocator), NULL);

again, this doesn't make sense since the allocator is already casted as a msdk
allocator
this should be called above

::: sys/msdk/gstmsdkmemory.h
@@ +59,3 @@
+  GST_MINI_OBJECT_FLAG_SET (mem, flag)
+#define GST_MSDK_MEMORY_FLAG_UNSET(mem, flag) \
+  GST_MEMORY_FLAG_UNSET (mem, flag)

you don't need to define these macros, afaiu

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.