[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #35 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364992:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=364992)

::: sys/msdk/gstmsdkbufferpool.c
@@ +93,3 @@
+    GST_INFO_OBJECT (pool, "created new allocator %" GST_PTR_FORMAT,
allocator);
+
+    gst_buffer_pool_config_set_allocator (config, allocator, NULL);

shouldn't you set the proper GstAllocationParams here?

--- Comment #36 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 364992:
 --> (https://bugzilla.gnome.org/review?bug=790752&attachment=364992)

::: sys/msdk/gstmsdkbufferpool.c
@@ +93,3 @@
+    GST_INFO_OBJECT (pool, "created new allocator %" GST_PTR_FORMAT,
allocator);
+
+    gst_buffer_pool_config_set_allocator (config, allocator, NULL);

shouldn't you set the proper GstAllocationParams here?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.