[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #40 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #24)
> (In reply to Víctor Manuel Jáquez Leal from comment #22)
> > Review of attachment 364889 [details] [review] [review]:
> > @@ +405,3 @@
> > +
> > +gint
> > +msdk_get_mfx_fourcc (GstVideoFormat format)
> > 
> > This function is useless since we already have gst_video_format_to_fourcc ()
> > 
> 
> Using gst_video_format_to_fourcc causes failure of vpp.(in case of I420 and
> BGRA)
> Seems that the required fourcc for the driver might be different.

Yeah, it seems for I420 and YV12 it uses YV12, and for BGRA it uses RGB4.
Perhaps we should remark this as exceptions.  

> 
> 
> > @@ +440,3 @@
> > +  mfx_info->AspectRatioW = info->par_n;
> > +  mfx_info->AspectRatioH = info->par_d;
> > +  mfx_info->PicStruct = MFX_PICSTRUCT_PROGRESSIVE;
> > 
> > you can get this also from the gstvideoinfo:
> > 
> > info->interlace_mode
> 
> I want to set MFX_PICSTRUCT_PROGRESSIVE by default.
> Because the values of GstVideoInterlaceMode and values of MFX_PICSTRUCT are
> very different. Probably the PicStruct might be set when needed after this
> call.

Yes, they are different, you would need a function that convert from
GstVideoInterlaceMode and GstVideoFieldOrder the according MFX_PICSTRUCT_

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.