[Bug 790752] msdk: supports bufferpool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790752

--- Comment #41 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Hyunjun Ko from comment #25)
> (In reply to Víctor Manuel Jáquez Leal from comment #23)
> > Review of attachment 364890 [details] [review] [review]:
> > 
> > @@ +232,3 @@
> > +  g_slice_free (mfxFrameSurface1, mem->surface);
> > +  mem->cache = NULL;
> > +  mem->surface = NULL;
> > 
> > have you have looked g_clear_pointer ()  ?
> > 
> 
> How do you use g_clear_pointer with g_slice_free?


yea, in the case of GSlice is not possible to use g_clear_pointer()

> I would remove NULL assignment since it's not necessary if you don't want to
> see them.
> 
> 
> > @@ +274,3 @@
> > +    return NULL;
> > +
> > +  allocator->image_info = *image_info;
> > 
> > what about, instead of storing the gstvideoinfo, you store the mfxFrameInfo
> > directy?
> > 
> > I mean, receive as parameter GstVideoInfo, but convert it and store it in
> > the allocator structure as mfxFrameInfo, then you don't need to execute the
> > conversion every time a surface is allocated.
> 
> The image_info is needed from msdk memory to map.
> If you don't like to call conversion at every allocation, we should have
> both.
> But I think this is fine since allocation happens only several times because
> it's managed by bufferpool.

D'accord

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.