[Bug 791258] amcvideoenc: when flushing, better handle IllegalStateException received from getOutputBuffer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791258

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365022|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 365022:
 --> (https://bugzilla.gnome.org/review?bug=791258&attachment=365022)

Thanks for your patch. The same is probably also necessary in the video decoder
and the audio elements? Can you check and provide patches?

::: sys/androidmedia/gstamcvideoenc.c
@@ +1021,3 @@
+    if (self->flushing) {
+      GST_ELEMENT_ERROR_FROM_ERROR (self, err);
+      GST_ERROR_OBJECT (self, "Error encountered, but flushing anyway");

You don't want to send an error message here probably. It's flushing, not
GST_FLOW_ERROR. Error messages are supposed to be fatal

@@ +1026,3 @@
+    goto failed_to_get_output_buffer;
+  } else if (!buf)
+    goto got_null_output_buffer;

Please add some {} here

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.