[Bug 791258] amcvideoenc: when flushing, better handle IllegalStateException received from getOutputBuffer
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Dec 5 14:35:14 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=791258
--- Comment #3 from Ursula Maplehurst <ursula at kangatronix.co.uk> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> You don't want to send an error message here probably. It's flushing, not
> GST_FLOW_ERROR. Error messages are supposed to be fatal
I think there are two options:
a) change the GST_ERROR_OBJECT to a GST_WARNING_OBJECT, reporting that the
problem has occurred;
b) remove the GST_ELEMENT_ERROR_FROM_ERROR/GST_ERROR_OBJECT and just do a
g_clear_error, hiding the problem;
It looks like b) may be more consistent with what other code is already doing
when flushing and an error has been picked up. What do you think?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list