[Bug 790470] glimagesink: subtitle don't rotate with video

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Dec 7 12:39:13 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=790470

--- Comment #6 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
To me the patch looks fine (except that you change an API, this breakage need
to be mentioned in the commit, and didn't fix the other elements using that
API).

Though, at higher level, you didn't solve the main issue.  There is a visual
difference when the transformation matrix is added before or after.

I can easily imagine a scenario where I want the text straight while on the
video is rotated. And other scenario where the text should
rotate/scale/whatever with the video. Which case so you implement, and why do
you think it's the right way for now ? All this need to be answered here and/or
in your commit message.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list