[Bug 790470] glimagesink: subtitle don't rotate with video

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790470

--- Comment #7 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Nicolas Dufresne (stormer) from comment #6)
> To me the patch looks fine (except that you change an API, this breakage
> need to be mentioned in the commit, and didn't fix the other elements using
> that API).

I will double check if the API change has impact on other components. On my
side, seems no compile error.

> 
> Though, at higher level, you didn't solve the main issue.  There is a visual
> difference when the transformation matrix is added before or after.
> 
> I can easily imagine a scenario where I want the text straight while on the
> video is rotated. And other scenario where the text should
> rotate/scale/whatever with the video. Which case so you implement, and why
> do you think it's the right way for now ? All this need to be answered here
> and/or in your commit message.

The patch will make subtitle always rotate with video, I think the case is
meaningless which text straight while on the video is rotated. If there are
some use cases for this scenario, please let me know.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.