[Bug 791423] New: videofilter: Should probably not change class property in set_caps()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791423

            Bug ID: 791423
           Summary: videofilter: Should probably not change class property
                    in set_caps()
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: nicolas at ndufresne.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Just stumbled across some code that does not seem quite safe:

gst_video_filter_set_caps():
+ if (fclass->transform_frame_ip == NULL)
+      GST_BASE_TRANSFORM_CLASS (fclass)->transform_ip_on_passthrough = FALSE;

This type of code is normally placed in a class init function I believe. I do
expect a class to be generally immutable (except maybe for aa thread safe
singleton). At least, I don't think it would be good practice to change the
function pointer dynamically in an instance, or change these kind of property.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.