[Bug 791423] videofilter: Should probably not change class property in set_caps()

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Dec 9 23:13:55 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=791423

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Especially it is actually not safe. Say you have class A inheriting from
videofilter and then class B inheriting from class A, and class B actually
defines a transform_ip. If class A is doing set_caps() before class B is
initialized, transform_ip_on_passthrough is going to be set to FALSE, and that
is then inherited by class B once it is initialized. If class B is initialized
before class A is doing set_caps(), it would get the previous value of
transform_ip_on_passthrough.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list