[Bug 791736] wavenc: fix tag and toc handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791736

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365692|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 365692:
 --> (https://bugzilla.gnome.org/review?bug=791736&attachment=365692)

Thanks, looks good in general just one comment :)

::: tests/check/elements/wavenc.c
@@ +146,3 @@
+{
+  guint32 result = GST_READ_UINT32_LE (info->data + *index);
+  (*index) += 4;

Maybe use GstByteReader for these things? It does exactly what you
reimplemented here :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.