[Bug 791736] wavenc: fix tag and toc handling

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=791736

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #365694|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 365694:
 --> (https://bugzilla.gnome.org/review?bug=791736&attachment=365694)

::: gst/wavenc/gstwavenc.c
@@ +998,3 @@
+        tag_setter = GST_TAG_SETTER (wavenc);
+        gst_tag_setter_merge_tags (tag_setter, tags,
+            gst_tag_setter_get_tag_merge_mode (tag_setter));

Tag setter and event tags should be kept separate and only be merged into a
temporary taglist before writing. The event tags are transient, they would be
reset when the event is shut down. Tag setter tags are forever until the
application sets a different tag list

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.