[Bug 749950] encoder: VP8: Add CBR Encoding mode

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Feb 9 12:14:08 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=749950

--- Comment #11 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 345285:
 --> (https://bugzilla.gnome.org/review?bug=749950&attachment=345285)

::: gst-libs/gst/vaapi/gstvaapiencoder_vp8.c
@@ +299,3 @@
+
+  /* RateControl params */
+  if (GST_VAAPI_ENCODER_RATE_CONTROL (encoder) == GST_VAAPI_RATECONTROL_CBR) {

this branch is spurious since this check was done at the beginning of this
function (line 267)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list