[Bug 749950] encoder: VP8: Add CBR Encoding mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=749950

--- Comment #12 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #10)
> Review of attachment 345285 [details] [review]:
> 
> @@ +368,3 @@
>    pic_param->sharpness_level = encoder->sharpness_level;
>  
> +  /* For CBR */
> 
> shouldn't this be assigned only if CBR is requested?
Those parameters are used only in CBR mode in driver.
In case of CQP, they are not used.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.