[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768248

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344628|none                        |reviewed
             status|                            |

--- Comment #12 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 344628:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=344628)

lgtm

::: tests/simple-encoder.c
@@ +197,3 @@
+  }
+
+  gst_vaapi_encoder_set_roi (encoder, roi_regions);

Looking at this, I guess that the approach of {add,del}_roi is the way to go.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.