[Bug 768248] vaapiencode: Add Encoding region-of-interest (ROI) support

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Feb 17 16:05:01 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=768248

--- Comment #13 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 344626:
 --> (https://bugzilla.gnome.org/review?bug=768248&attachment=344626)

::: gst-libs/gst/vaapi/gstvaapiencoder.c
@@ +1227,3 @@
+  guint roi_num, i;
+
+  g_return_if_fail (roi_regions != NULL);

Is is possible to add/delete ROIs when the encoder is already processing a
stream? 

If not, we should also rely on the queued_codedbuf_num

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list