[Bug 779309] h264parse: Include `interlace-mode` in caps

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 27 13:48:18 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779309

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346815|accepted-commit_now         |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 346815:
 --> (https://bugzilla.gnome.org/review?bug=779309&attachment=346815)

::: gst/videoparsers/gsth264parse.c
@@ +1872,3 @@
+
+      gst_caps_set_simple (caps, "interlace-mode", G_TYPE_STRING,
+          gst_video_interlace_mode_to_string (imode), NULL);

Actually no. You should prefer what upstream has given in the caps, if
anything, and only otherwise set your own value

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list