[Bug 779309] h264parse: Include `interlace-mode` in caps

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Feb 27 13:49:19 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=779309

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Review of attachment 346815 [details] [review]:
> 
> ::: gst/videoparsers/gsth264parse.c
> @@ +1872,3 @@
> +
> +      gst_caps_set_simple (caps, "interlace-mode", G_TYPE_STRING,
> +          gst_video_interlace_mode_to_string (imode), NULL);
> 
> Actually no. You should prefer what upstream has given in the caps, if
> anything, and only otherwise set your own value

Indeed, missed that, on it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list