[Bug 758257] adaptivedemux: don't expose pads until caps are known

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=758257

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343079|none                        |reviewed
             status|                            |

--- Comment #15 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 343079:
 --> (https://bugzilla.gnome.org/review?bug=758257&attachment=343079)

I don't understand this patch. My previous patch split the prepare_streams and
expose_streams steps into 2 functions, and only calls expose when a buffer is
seen.

The problem with blocking inside expose_streams() as well is that it will block
an application seek() thread (usually the main thread) for an unknown length of
time until data has been downloaded from the server, or a timeout if data
doesn't arrive for a long time.

The parts of the patch about storing events as sticky events seem OK as an
optimisation, but shouldn't have fixed any actual bug afaict.

I suspect the only part we actually need is the part that moves clearing the
do_block flag after removing old pads?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.