[Bug 758257] adaptivedemux: don't expose pads until caps are known

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Jan 9 13:10:13 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=758257

Jan Schmidt <thaytan at noraisin.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #343080|none                        |reviewed
             status|                            |

--- Comment #16 from Jan Schmidt <thaytan at noraisin.net> ---
Review of attachment 343080:
 --> (https://bugzilla.gnome.org/review?bug=758257&attachment=343080)

Generally seems OK. The other patches need to land first.

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +278,3 @@

+static void gst_adaptive_demux_start_tasks (GstAdaptiveDemux * demux,
+    gboolean is_preroll);

Instead of 'is_preroll', call the variable 'start_preroll_streams' please - I
think it's clearer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list