[Bug 776983] opusenc does not discard silence if DTX enabled

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776983

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |olivier.crete at ocrete.ca

--- Comment #7 from Olivier Crête <olivier.crete at ocrete.ca> ---
Marking it as FLAG_GAP, and then dropping it either in the payloader or
pre_push() both seem fine. The question is how muxing to Ogg (or other
containers) is affected by dropping DTX frames.

Comfort noise generation should be triggered when the jitterbuffer emits an
event because an expected buffer is missing.

I'm not sure what a drop-dtx property would do more than just turning off DTX
in practice, for Opus, the codec compresses enough that I would expect that the
overhead of sending "empty" dtx packets would make you lose half of the benefit
anyway.

If the jitterbuffer goes crazy in presence of DTX, this is definitely something
that should be fixed in the JB. DTX is a real world feature we should support.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.