[Bug 776983] opusenc does not discard silence if DTX enabled

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=776983

--- Comment #8 from Nubosch <andreas.kling at gmail.com> ---
(In reply to Olivier Crête from comment #7)
> Marking it as FLAG_GAP, and then dropping it either in the payloader or
> pre_push() both seem fine. The question is how muxing to Ogg (or other
> containers) is affected by dropping DTX frames.

I decided to drop in the payloader, so everything on a local machine is not
affected by this change. I expect the issues in a muxer will be the same as for
e.g. pulsesink "discontinuity in audio"

> Comfort noise generation should be triggered when the jitterbuffer emits an
> event because an expected buffer is missing.

see below

> I'm not sure what a drop-dtx property would do more than just turning off
> DTX in practice, for Opus, the codec compresses enough that I would expect
> that the overhead of sending "empty" dtx packets would make you lose half of
> the benefit anyway.

100% ACK.

> If the jitterbuffer goes crazy in presence of DTX, this is definitely
> something that should be fixed in the JB. DTX is a real world feature we
> should support.

I'm in doubt I won't have the time to look into this in the near future.
At least I opened a new bug report documenting what I know so far.

https://bugzilla.gnome.org/show_bug.cgi?id=777319

I really hope I can come back to this after solving my 1001 network issues not
related to gstreamer.

many thanks for your help!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.