[Bug 762884] rtspsrc: allow to control headers via properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762884

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344556|none                        |needs-work
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 344556:
 --> (https://bugzilla.gnome.org/review?bug=762884&attachment=344556)

::: gst-libs/gst/rtsp/gstrtspmessage.c
@@ +98,3 @@
+
+static GstRTSPMessage *gst_rtsp_message_boxed_copy (GstRTSPMessage * orig);
+static void gst_rtsp_message_boxed_free (GstRTSPMessage * msg);

Instead of forward declarations, just move the function definitions above
G_DEFINE_BOXED_TYPE() :)

@@ +115,3 @@
+
+static void
+gst_rtsp_message_boxed_free (GstRTSPMessage * msg)

Why a new function? Can't you just use gst_rtsp_message_free() here?

@@ +554,3 @@
+ * Returns: a #GstRTSPResult
+ *
+ * Since: ???

Since: 1.12

(also in the other patch, then I can merge)

@@ +589,3 @@
+      break;
+    default:
+      return GST_RTSP_OK;

This should probably fail. For any other kind of message, we don't properly
copy, or do we? If so add all here for which we properly copy explicitly so
that whenever someone adds a new type it will be noticed that this code here
has to be extended

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.