[Bug 762884] rtspsrc: allow to control headers via properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762884

--- Comment #22 from Matt Staples <staples255 at gmail.com> ---
Review of attachment 344556:
 --> (https://bugzilla.gnome.org/review?bug=762884&attachment=344556)

::: gst-libs/gst/rtsp/gstrtspmessage.c
@@ +83,3 @@
+  copy->field = kv->field;
+  copy->value = g_strdup (kv->value);
+  g_return_if_fail (kv != NULL);

As long as I'm making another round of changes...  The new function,
key_value_copy isn't handling the case that copy already has strings assigned. 
It arguably doesn't need to since this function is static and isn't used that
way.  But in hindsight, it's probably better to eliminate this and do this work
in key_value_append.

@@ +98,3 @@
+
+static GstRTSPMessage *gst_rtsp_message_boxed_copy (GstRTSPMessage * orig);
+static void

Agreed. (I was just blindly following the GstSDPMessage pattern. :-) )

@@ +589,3 @@
+      break;
+    default:
+  if (ret != GST_RTSP_OK)

Ok, I'll add a (success) case for the remaining enum value,
GST_RTSP_MESSAGE_INVALID, and make default return failure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.