[Bug 762884] rtspsrc: allow to control headers via properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762884

--- Comment #23 from Matt Staples <staples255 at gmail.com> ---
Review of attachment 344556:
 --> (https://bugzilla.gnome.org/review?bug=762884&attachment=344556)

::: gst-libs/gst/rtsp/gstrtspmessage.c
@@ +115,3 @@
+
+static void
+  g_array_append_val (array, kvcopy);

Another case of just following the GstSDPMessage pattern.  In this case though,
It think the wrapper function is actually necessary since gst_rtsp_message_free
returns a value while GBoxedFreeFunc is defined as void.  I could get it to
compile by using ((GBoxedFreeFunc)gst_rtsp_messageFree) in the call to
G_DEFINE_BOXED_TYPE, but I think that could result in stack corruption at
runtime since the caller wouldn't reserve the necessary stack space for the
return value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.