[Bug 753323] mpegts: add support for JPEG 2000 to mpegtsmux and tsdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753323

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353329|none                        |needs-work
             status|                            |

--- Comment #97 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 353329:
 --> (https://bugzilla.gnome.org/review?bug=753323&attachment=353329)

::: gst/videoparsers/gstjpeg2000parse.c
@@ +654,3 @@
     }

+

Extra empty line not needed

@@ +659,3 @@
+    if (colorimetry_string) {
+      gchar *colorimetry = g_strdup (colorimetry_string);
+      if (colorimetry) {

If colorimetry_string is not NULL, then colorimetery will also not be NULL here

@@ +662,3 @@
+        gst_caps_set_simple (src_caps, "colorimetry", G_TYPE_STRING,
+            colorimetry, NULL);
+        g_free (colorimetry);

Why the g_strdup() and then g_free() again immediately?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.