[Bug 753323] mpegts: add support for JPEG 2000 to mpegtsmux and tsdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753323

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353332|none                        |needs-work
             status|                            |

--- Comment #98 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 353332:
 --> (https://bugzilla.gnome.org/review?bug=753323&attachment=353332)

Why exactly does it segfault and what does this patch fix exactly and how?

::: gst/mpegtsmux/mpegtsmux.c
@@ +786,3 @@
+         gst_allocator_free (default_allocator, private_data);
+         gst_object_unref (default_allocator);
+         GST_ERROR_OBJECT (pad, "Missing JPEG 2000 profile");

Why so complicated and not just gst_memory_unref (private_data)?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.