[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 355004:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=355004)

I guess you missed to pass the code through gst-indent

::: sys/kms/gstkmssink.c
@@ +574,3 @@

+  self->hdisplay = self->preferred_width = crtc->mode.hdisplay;
+  self->vdisplay = self->preferred_height= crtc->mode.vdisplay;

code style (space between = )

@@ +724,3 @@
+        "height", G_TYPE_INT, self->preferred_height, NULL);
+  }
+  GST_DEBUG_OBJECT (self, "allowed caps %"GST_PTR_FORMAT, caps);

ditto

@@ +733,3 @@
   }
+  g_mutex_unlock (&self->glock);
+  GST_DEBUG_OBJECT (self, "out caps %"GST_PTR_FORMAT, out_caps);

ditto

@@ +1261,3 @@
+      dst.h = height;
+
+      gst_video_sink_center_rect (src, dst, &result, TRUE );

ditto

@@ +1264,3 @@
+
+      kmssink->preferred_x = x+result.x;
+      kmssink->preferred_y = y+result.y;

ditto

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.