[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 355004:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=355004)

::: sys/kms/gstkmssink.c
@@ +1333,3 @@
+    self->original_heigth = GST_VIDEO_INFO_HEIGHT (&self->vinfo);
+  }
+

wouldn't be clearer to set this in gst_kms_sink_set_caps() when reconfigure is
TRUE?

::: sys/kms/gstkmssink.h
@@ +77,3 @@
+  gint preferred_y;
+  gint preferred_width;
+  gint preferred_height;

wouldn't be better to use a GstVideoRectangle here instead of these four
integers?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.