[Bug 781446] rtsp: Add support for the new RTSP 2.0 protocol (rfc7826)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781446

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354932|none                        |reviewed
             status|                            |

--- Comment #10 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 354932:
 --> (https://bugzilla.gnome.org/review?bug=781446&attachment=354932)

The Random-Access features handling seems to be a bit incomplete, a casual
glance at the RFC sounds like they have added a lot of different modes!

Otherwise looks good to me

::: gst/rtsp/gstrtspsrc.c
@@ +2513,3 @@
+        if (seekable) {
+          if (src->seekable > 0.0) {
+            start = src->last_pos - src->seekable * GST_SECOND;

Why would start not be 0 ? I understand that this "seekable" value is the
maximum distance between two keyframes, no ?

Should the value be used here be for Time-Duration? Then you also want
segment_end to be src->last_pos + src->time_duration ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.