[Bug 781446] rtsp: Add support for the new RTSP 2.0 protocol (rfc7826)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781446

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354931|none                        |reviewed
             status|                            |

--- Comment #11 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 354931:
 --> (https://bugzilla.gnome.org/review?bug=781446&attachment=354931)

Generally looks good, just one little nit related to the one on the rtspsrc
patch about the seeking stuff.

::: gst/rtsp-server/rtsp-media.c
@@ +127,2 @@
   gboolean is_live;
+  GstClockTimeDiff seekable;

Is this really a time diff? The current mode seems to only have -1, 0 and
MAXINT ? So like a 3 flags enum? Reading from the spec, this should really be
the worse inter-iframe distance (which we can't query in Gst right now). I dont
think we have ways to query information about modes like "live + recording"
from update elements, I guess ideally we'd add more data to the seeking query
for this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.