[Bug 781446] rtsp: Add support for the new RTSP 2.0 protocol (rfc7826)

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Jul 9 14:07:58 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=781446

--- Comment #14 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 354932:
 --> (https://bugzilla.gnome.org/review?bug=781446&attachment=354932)

::: gst/rtsp/gstrtspsrc.c
@@ +2513,3 @@
+        if (seekable) {
+          if (src->seekable > 0.0) {
+            start = src->last_pos - src->seekable * GST_SECOND;

I guess you mean if seekable == 0. If it is > 0, user can basically seek
wherever he wants.

In the case seekable == 0, I consider the seek query should let the user know,
and it is represented in the following branch with start=0 and duration=0,
maybe this is not the right way though, I am not sure.

I mean in practice if the user seeks to 1hr, he does not want to seek to 0,
which is afaiu what you are proposing here.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list