[Bug 781446] rtsp: Add support for the new RTSP 2.0 protocol (rfc7826)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781446

--- Comment #15 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 354932:
 --> (https://bugzilla.gnome.org/review?bug=781446&attachment=354932)

::: gst/rtsp/gstrtspsrc.c
@@ +2513,3 @@
+        if (seekable) {
+          if (src->seekable > 0.0) {
+            start = src->last_pos - src->seekable * GST_SECOND;

Unless I misunderstand the seeking query, the values passed to the last two
parameters of gst_query_set_seeking () are the start and end position to which
seeking is possible? So if you where to return "10, 20", a seek to 5 or to 25
should fail (but to 10, 15 or 20 should work).

As a side-note, we need better documentation for the gst_query_*_seeking()
parameters.

The ==0 case is fine, it's the other one I'm worried about.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.