[Bug 781446] rtsp: Add support for the new RTSP 2.0 protocol (rfc7826)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781446

--- Comment #16 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 354932:
 --> (https://bugzilla.gnome.org/review?bug=781446&attachment=354932)

::: gst/rtsp/gstrtspsrc.c
@@ +2513,3 @@
+        if (seekable) {
+          if (src->seekable > 0.0) {
+            start = src->last_pos - src->seekable * GST_SECOND;

Sorry, I misinterpreted you previous comment.

The idea here is to make sure that we handle the case where the server is able
to do live retention, that formula is wrong now (I changed the meaning of
seekable during dev and looks like I did not fix it properly), I think the
computation should now be:

    start = (src->seekable == G_MAXINT64) ? 0 : src->last_pos - src->seekable;

Also what you explain here is racy and I think we need the seek to clamp to the
start position in the case we have a running window of possible seeking time
(not totally related to that issue though).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.