[Bug 784069] Add support for OMX_UseBuffer in gstomxvideodec

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784069

--- Comment #3 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 354712:
 --> (https://bugzilla.gnome.org/review?bug=784069&attachment=354712)

Shouldn't we also check if the buffers provided by the pool are big enough?

::: omx/gstomxvideodec.c
@@ +841,3 @@
+          gst_buffer_map (buffer, &info, GST_MAP_WRITE);
+          images = g_list_append (images, info.data);
+              "Failed to allocated %d-th buffer of type %s, n_mem: %d", i,

Is it safe to unmap already while the data pointer is still stored in images
and will be used later by gst_omx_port_use_buffers()?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.